Test index into swizzle for assignment - #4687
Merged
Merged
Conversation
Array-like indexing into swizzle views was added to the swizzle assignment WGSL language feature specification in a recent change to the spec PR: gpuweb/gpuweb@4b8daf8
|
Results for build job (at 56bea06): -webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 16 cases, 128 subcases (~8/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_compound_assignment:* - 4 cases, 32 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 21 cases, 168 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_compound_assignment:* - 7 cases, 56 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:dynamic_index_into_swizzle:* - 30 cases, 228 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:indexed_swizzle_eval_order:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:indexed_swizzle_compound_eval_order:* - 1 cases, 1 subcases (~1/case)
-webgpu:shader,validation,statement,swizzle_assignment:invalid_index_into_swizzle_view:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,validation,statement,swizzle_assignment:index_into_swizzle_view:* - 30 cases, 30 subcases (~1/case)
+webgpu:shader,validation,statement,swizzle_assignment:dynamic_index_into_swizzle_view:* - 6 cases, 6 subcases (~1/case)
-TOTAL: 285244 cases, 2346076 subcases
+TOTAL: 285319 cases, 2346405 subcases |
alan-baker
approved these changes
Jul 27, 2026
Contributor
Author
|
Also modified tests to allow duplicates in the nested swizzle view being indexed, since this is actually allowed by the spec. |
alan-baker
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array-like indexing into swizzle views was added to the swizzle assignment WGSL language feature specification in a recent change to the spec PR: gpuweb/gpuweb@4b8daf8
These new cases have been tested against the updated dawn implementation at: https://dawn-review.googlesource.com/c/dawn/+/327436
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.