Add chained swizzle assignment tests - #4688
Merged
Merged
Conversation
Add validation and execution tests for chained swizzles on the LHS of an assignment. These are valid with the swizzle_assignment language feature as long as the final indices actually assigned are free from duplicate targets. Bug: crbug.com/539634915
|
Results for build job (at b697f76): -webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 21 cases, 168 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 23 cases, 184 subcases (~8/case)
+webgpu:shader,validation,statement,swizzle_assignment:chained_swizzle:* - 8 cases, 8 subcases (~1/case)
-TOTAL: 285319 cases, 2346405 subcases
+TOTAL: 285329 cases, 2346429 subcases |
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jul 28, 2026
In the WGSL swizzle assignment language feature, duplicate components are permitted in swizzles on the LHS of an assignment provided that the final collapsed swizzle that will actually be assigned to is free from duplicates. Fix validation to account for this. These have also been tested against new CTS: gpuweb/cts#4688 Bug: 539634915 Change-Id: I3cc547b1f48d37354379f8f08ec4c913745be3d7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/327796 Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Natalie Chouinard <chouinard@google.com>
alan-baker
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation and execution tests for chained swizzles on the LHS of an assignment. These are valid with the swizzle_assignment language feature as long as the final indices actually assigned are free from duplicate targets.
These have been tested against the Dawn implementation in: https://dawn-review.googlesource.com/c/dawn/+/327796
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.