Remove serialization, bump 0.2.3, README overhaul#92
Merged
CalNightingale merged 6 commits intomainfrom Feb 17, 2026
Merged
Conversation
This feature was designed for Apache Beam workflows to pass CODObjects between DoFns, but COD usage has evolved to be atomic within `with` blocks and nobody uses this anymore. Removing it simplifies the constructor (5 fewer internal params), eliminates lock re-acquisition logic in CODLocker, and reduces documentation overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The locking documentation still referenced the deprecated lock=True/False API, dirty operations, and .sync() calls. Updated to document the current mode="r"/"w"/"a" system with auto-sync on context exit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The README claimed locks hang on any exception, but the code actually releases the lock on user exceptions (only local state affected) and only leaves it hanging when sync itself fails (remote may be corrupt). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
requires-python was >=3.8 but the library requires 3.11+ and doesn't support 3.14 yet. Added classifiers so the PyPI Python versions badge renders correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CalNightingale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serialization removal:
serialize()anddeserialize()methods from CODObject — this Beam workflow pattern is no longer usedlock_generation,metadata,_tar_synced,_metadata_synced,_thumbnail_synced) that existed solely to support deserializationCODLocker.acquire()by removing the lock re-acquisition branchREADME overhaul:
mode="r"/"w"/"a"system (was still documenting deprecatedlock=True/False)Housekeeping:
pyproject.tomland fixedrequires-pythonfrom>=3.8to>=3.11,<3.14Test plan
python -m unittest cloud_optimized_dicom.tests.test_metadata_serialization -v— all 8 passpython -m unittest cloud_optimized_dicom.tests.test_cod_object -v— non-GCP test passes, GCP tests fail on auth (pre-existing)serialize/deserializeno longer exist onCODObjectSISKIN_ENV_ENABLED=1🤖 Generated with Claude Code