Skip to content

Fix CI passing despite test failures#93

Merged
CalNightingale merged 1 commit intomainfrom
fix/ci-pipefail
Feb 19, 2026
Merged

Fix CI passing despite test failures#93
CalNightingale merged 1 commit intomainfrom
fix/ci-pipefail

Conversation

@CalNightingale
Copy link
Collaborator

Summary

  • Add set -o pipefail to the test workflow so the pipeline python ... | tee test_output.txt propagates the unittest exit code instead of always returning tee's exit code (0)
  • This was masking real test failures — the _metadata initialization bug (36 errors, 4 failures) went undetected because CI showed green

Test plan

  • Verify this CI run fails (exposing the existing _metadata bug)
  • Follow-up PR will fix the actual bug

🤖 Generated with Claude Code

Without `set -o pipefail`, the pipeline `python ... | tee test_output.txt`
returns tee's exit code (always 0), masking unittest failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CalNightingale CalNightingale marked this pull request as ready for review February 19, 2026 15:01
@CalNightingale CalNightingale merged commit 9209d4c into main Feb 19, 2026
1 of 2 checks passed
@CalNightingale CalNightingale deleted the fix/ci-pipefail branch February 19, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant