Fix CI passing despite test failures#93
Merged
CalNightingale merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Without `set -o pipefail`, the pipeline `python ... | tee test_output.txt` returns tee's exit code (always 0), masking unittest failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -o pipefailto the test workflow so the pipelinepython ... | tee test_output.txtpropagates the unittest exit code instead of always returning tee's exit code (0)_metadatainitialization bug (36 errors, 4 failures) went undetected because CI showed greenTest plan
_metadatabug)🤖 Generated with Claude Code