feat: pyroscope.enrich component#4797
Conversation
|
|
docs/sources/reference/components/pyroscope/pyroscope.enrich.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.enrich.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.enrich.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.enrich.md
Outdated
Show resolved
Hide resolved
AndreZiviani
force-pushed
the
pyroscope-enrich
branch
from
a7ad056 to
a10cb15
Compare
|
hey @clayton-cornell , any other changes required? can you allow the ci/tests to run? |
AndreZiviani
force-pushed
the
pyroscope-enrich
branch
from
0fc33fb to
8cfa344
Compare
|
@dehaansa ci errors seems unrelated to my changes, let me know when you can review it again so that I can rebase and fix merge conflicts |
dehaansa
left a comment
dehaansa
left a comment
There was a problem hiding this comment.
LGTM, merge/rebase for changelog and we can get this merged.
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
AndreZiviani
force-pushed
the
pyroscope-enrich
branch
from
8cfa344 to
74c425d
Compare
|
done @dehaansa , thanks! |
Thanks for the contribution! |
clayton-cornell
added
the
type/docs
* feat: pyroscope.enrich component * chore: Improve docs Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Sam DeHaan <sam.dehaan@grafana.com>
|
hey @dehaansa my contribution was removed from changelog but the code itself is still on the repo, is this expected? there have been multiple releases since this PR, when can I expect to have a release with this feature? |
|
@AndreZiviani Sorry for the confusion! We've recently updated to using release-please to generate the changelog so unreleased content is no longer listed in the changelog before release. Sadly 1.12 release started in mid november before this PR was merged, it had some release process issues so the actual release was delayed, but we didn't add non-bugfixes afterwards. The pyroscope.enrich component will land in 1.13, early February 2026 is the current target. |
|
I see, thanks! |
4 participants
PR Description
Adds
pyroscope.enrichcomponent based on #2882 and other pyroscope components, it allows you to add labels retrieved fromdiscovery.*to the resulting profilesWhich issue(s) this PR fixes
Fixes #4767
Notes to the Reviewer
PR Checklist