enhancement: support http SD in scrapeconfigs#4826
Conversation
|
Hey, could you give some more context for this feature? Any documentation on how this works with the operator? |
|
Of course. So basically, the prometheus operator scrape configs now support 21 différent discovery mechanisms. The main ones are documented here: https://prometheus-operator.dev/docs/developer/scrapeconfig/#use-scrapeconfig-to-scrape-an-external-target This allows the operator to discover non static targets via différent protocols and I need the http service discovery support :D |
internal/component/prometheus/operator/configgen/config_gen_scrapeconfig.go
Outdated
Show resolved
Hide resolved
internal/component/prometheus/operator/configgen/config_gen_scrapeconfig.go
Outdated
Show resolved
Hide resolved
internal/component/prometheus/operator/configgen/config_gen_scrapeconfig.go
Outdated
Show resolved
Hide resolved
|
Don't we need a doc update in I'm guessing we should add something like this:
As well as something describing the HTTP service discovery, and extend or add to the examples... (with a YML scrape config and the JSON return)? |
|
@clayton-cornell what do you think about this documentation update? |
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
* enhancement: support http SD in scrapeconfigs * Update CHANGELOG.md * Apply suggestions from code review * update-documentation * Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
PR Description
This pull request adds support for HTTP service discovery to the prometheus.operator.scrapeconfigs component, allowing users to specify httpSDConfigs in ScrapeConfig CRDs.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist