Skip to content

enhancement: support http SD in scrapeconfigs#4826

Merged
kalleep merged 12 commits intografana:mainfrom
QuentinBisson:add-scrape-config-http-service-discovery
Dec 5, 2025
Merged

enhancement: support http SD in scrapeconfigs#4826
kalleep merged 12 commits intografana:mainfrom
QuentinBisson:add-scrape-config-http-service-discovery

Conversation

@QuentinBisson
Copy link
Contributor

PR Description

This pull request adds support for HTTP service discovery to the prometheus.operator.scrapeconfigs component, allowing users to specify httpSDConfigs in ScrapeConfig CRDs.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@QuentinBisson QuentinBisson requested a review from a team as a code owner November 12, 2025 15:05
@kalleep
Copy link
Contributor

kalleep commented Nov 14, 2025

Hey, could you give some more context for this feature? Any documentation on how this works with the operator?

@QuentinBisson
Copy link
Contributor Author

Of course. So basically, the prometheus operator scrape configs now support 21 différent discovery mechanisms. The main ones are documented here: https://prometheus-operator.dev/docs/developer/scrapeconfig/#use-scrapeconfig-to-scrape-an-external-target

This allows the operator to discover non static targets via différent protocols and I need the http service discovery support :D

@clayton-cornell
Copy link
Contributor

clayton-cornell commented Dec 2, 2025

Don't we need a doc update in prometheus.operator.scrapeconfigs for this change?

I'm guessing we should add something like this:

ScrapeConfig resources support multiple service discovery methods including static configurations and HTTP service discovery for dynamic target discovery.

As well as something describing the HTTP service discovery, and extend or add to the examples... (with a YML scrape config and the JSON return)?

@QuentinBisson
Copy link
Contributor Author

@clayton-cornell what do you think about this documentation update?

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Dec 3, 2025
QuentinBisson and others added 4 commits December 4, 2025 10:06
…or.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…or.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…or.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@kalleep kalleep merged commit 0d0fb65 into grafana:main Dec 5, 2025
39 checks passed
dehaansa pushed a commit to madhub/alloy that referenced this pull request Dec 10, 2025
* enhancement: support http SD in scrapeconfigs

* Update CHANGELOG.md

* Apply suggestions from code review

* update-documentation

* Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants