Conversation
jharvey10
approved these changes
Nov 13, 2025
Contributor
jharvey10
left a comment
jharvey10
left a comment
There was a problem hiding this comment.
LGTM. Checked through the file history (and back to agent as well) to see if there was a historical reason why this additional config remained here, but didn't find anything.
dehaansa
added a commit
to madhub/alloy
that referenced
this pull request
Dec 10, 2025
* Fix the way loki.write configures HTTP2 * Ensure http2 is configurable for loki wal clients as well * Update tests to use default HTTP config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Somehow this has been forcibly disabled in code since Alloy 1.0 and beyond.
Which issue(s) this PR fixes
Fixes #4595
Notes to the Reviewer
PR Checklist