Merged
Conversation
MyDigitalLife
requested review from
a team and
clayton-cornell
as code owners
|
|
clayton-cornell
added
the
type/docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for propagating the traceparent header from Alloy to downstream services like Mimir, enabling distributed tracing across service boundaries. The feature is implemented as an optional configuration flag that defaults to false to maintain backward compatibility.
- Adds
send_traceparentboolean option to thetracingconfiguration block - Configures OpenTelemetry's global text map propagator with TraceContext and Baggage propagators when enabled
- Updates documentation and changelog to reflect the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/runtime/tracing/tracing.go | Adds SendTraceparent field to Options struct and configures global OTEL propagator in New() and Update() methods |
| docs/sources/reference/config-blocks/tracing.md | Documents the new send_traceparent configuration option with description and example usage |
| CHANGELOG.md | Records the addition of the new traceparent propagation feature |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kalleep
reviewed
Nov 19, 2025
Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
kalleep
reviewed
Nov 19, 2025
Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
dehaansa
approved these changes
Nov 20, 2025
clayton-cornell
approved these changes
Nov 20, 2025
dehaansa
pushed a commit
to madhub/alloy
that referenced
this pull request
Dec 10, 2025
* Added an option to enable the sending to traceparent headers * Updated CHANGELOG.md * Fixed typo * Update docs/sources/reference/config-blocks/tracing.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove duplicate code and fix changing of send_traceparent option * Improved * Moved to 1 append call * Improved naming * Improved naming * Update internal/runtime/tracing/tracing.go Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com> * Update internal/runtime/tracing/tracing.go Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com> * Update internal/runtime/tracing/tracing.go Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This change enables the user to propagate the traceparent header. This allows the user to trace a call from alloy to other services like Mimir. I made it a optional setting that is false by default to not change the current way it work.
Which issue(s) this PR fixes
Fixes ##2521
Notes to the Reviewer
PR Checklist