Skip to content

Remove experimental flag from stage.windowsevent#4879

Merged
kgeckhart merged 1 commit intomainfrom
kgeckhart/ga-stage-windowsevent
Nov 19, 2025
Merged

Remove experimental flag from stage.windowsevent#4879
kgeckhart merged 1 commit intomainfrom
kgeckhart/ga-stage-windowsevent

Conversation

@kgeckhart
Copy link
Contributor

PR Description

Removes the experimental requirement from stage.windowsevent which hasn't changed since it was originally introduced in Feb. No doc changes required because the docs didn't mention it was experimental.

PR Checklist

  • CHANGELOG.md updated

@kgeckhart kgeckhart requested a review from a team as a code owner November 18, 2025 22:06
@kgeckhart kgeckhart force-pushed the kgeckhart/ga-stage-windowsevent branch from aed12e9 to 2b993e6 Compare November 19, 2025 14:08
@kgeckhart kgeckhart enabled auto-merge (squash) November 19, 2025 14:24
@kgeckhart kgeckhart merged commit 22de0cf into main Nov 19, 2025
42 checks passed
@kgeckhart kgeckhart deleted the kgeckhart/ga-stage-windowsevent branch November 19, 2025 14:26
@ptodev
Copy link
Contributor

ptodev commented Nov 19, 2025

I had a quick look at the docs to see if there's anything weird about this feature that we might need to change. The only thing that stood out to me was:

When overwrite_existing is set to true, the stage overwrites existing extracted data fields with the same name. If set to false, the _extracted suffix is appended to an existing field name.

I wonder what happens if the field in the event log is called "testField", but there is already both a "testField" and a "testField_extracted" in the extracted map. This is the only thing I could think of that we might need to change in the future... but I don't mind if we mark this stable and look into it more later on.

@kgeckhart kgeckhart mentioned this pull request Nov 19, 2025
jharvey10 added a commit that referenced this pull request Nov 19, 2025
* fix: no longer drop request if stream is dropped in loki.source.api (#4834)

* fix: add ForceShutdown that will cancel in-flight requests before
stopping server

* Split into multiple files and add LogsBatchReceiver

* don't drop request when relabel rules drops a specific stream

* fix: use loki.LogsBatchReceiver to ensure all entries in a request is sent down the
pipeline

* add changelog

* add checks for entries and use sync once to close channel

* update changelog for next rc

* Fix flaky tests: port in for loki source api tests and logs integration test (#4875)

* Fix port in use flakyness for loki source api tests

* Pin loki container version for integration tests

* Add a new mimir.alerts.kubernetes component (#3448)

* Add a new mimir.alerts.kubernetes component

* Sync Mimir periodically, test the case of a CRD deletion

* Add TODOs

* Longer test timeout

* Check if pods are running

* Apply suggestions from code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Fix metric doc

* Fix changelog

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Remove experimental flag from stage.windowsevent (#4879)

---------

Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
Co-authored-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
dehaansa pushed a commit to madhub/alloy that referenced this pull request Dec 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants