feat: add delay option to CW exporter#4936
Conversation
8b86fc1 to
2bfe083
Compare
kalleep
left a comment
There was a problem hiding this comment.
Changes looks mostly fine to me but I left one question, also I can see that @kgeckhart was involved with the original pr so maybe he have more context around this
|
Hey @kalleep, @kgeckhart anything I can do to help this move forwards? |
There was a problem hiding this comment.
Let's ship this and I'll open an issue upstream to add a 2 minute delay for 1 minute periods. We know from running our hosted product that 1 minute periods require a 2 minute delay but YACE doesn't do this for you and you must know to do it yourself instead. The referenced alloy issue regarding metrics being too low is for 1 minute periods as well.
We still need to expose delay because there are other use cases where adding delay can be necessary but they are the exception and in most cases the default roundingPeriod logic works as expected.
* feat: add delay option to CW exporter * linting + changelog * fix incorrect support for delay in static jobs * fix changelog
PR Description
Add
delayoption toprometheus.exporter.cloudwatchcomponent to delay scraping of metrics to account for CloudWatch ingestion latency.Export
yace_.*metrics from the underlying YACE Exporter toprometheus.exporter.cloudwatch.Which issue(s) this PR fixes
Fixes #3929, Partially #398
Notes to the Reviewer
Warning
This is vibe coded, so it might not be the best. However testing a local build it works as I'd expect.
Validation of
yace_.*metrics:delayoption present in alloy ui:CloudWatch vs Prometheus
PR Checklist