Skip to content

stage.cri: remove wrong output stage#5002

Merged
kalleep merged 2 commits intomainfrom
kalleep/loki-process-cri
Dec 4, 2025
Merged

stage.cri: remove wrong output stage#5002
kalleep merged 2 commits intomainfrom
kalleep/loki-process-cri

Conversation

@kalleep
Copy link
Contributor

@kalleep kalleep commented Dec 4, 2025

PR Description

Noticed when running with debug logging enabled.

This stage was originally added to promtail in grafana/loki#6177. For some reason it had two output stages, one for content and one for flags.

stage.Output will replace log line of entries and that should always be content. The regexp stage for cri will extract time, stream, flags and content content. Because tags was never extracted this was never a problem but we should not have this stage.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@kalleep kalleep requested a review from a team as a code owner December 4, 2025 09:32
@kalleep kalleep merged commit f2f08fc into main Dec 4, 2025
42 of 43 checks passed
@kalleep kalleep deleted the kalleep/loki-process-cri branch December 4, 2025 12:43
dehaansa pushed a commit to madhub/alloy that referenced this pull request Dec 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants