fix: add StoreBuilder to mimir.alerts.kubernetes eventProcessor#5010
fix: add StoreBuilder to mimir.alerts.kubernetes eventProcessor#5010ptodev merged 4 commits intografana:mainfrom
Conversation
|
@synthe102 thank you! I added some integration and unit tests to your branch. |
|
Thanks @ptodev ! |
|
@synthe102 I added an entry to the changelog and tagged you, I hope you don't mind. |
|
@synthe102 Do you mind rebasing your branch please? |
|
I've tested this, and there is another logical error. It's not directly related to the issue, but maybe it makes sense to fix it here. alloy/internal/component/mimir/alerts/kubernetes/events.go Lines 178 to 180 in 8c0090c And it breaks the config, since it implicitly adds the to the main route: Because we don't use the Alertmanager CRD, where we can set the alertmanagerConfigMatcherStrategy. |
|
Hi @artemlive, do you mind opening another issue for this please? |
…ana#5010) * fix: add StoreBuilder to mimir.alerts.kubernetes eventProcessor Fixes grafana#4975 * Add integration and unit tests * Fix lint error * Add changelog entry --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
…ana#5010) * fix: add StoreBuilder to mimir.alerts.kubernetes eventProcessor Fixes grafana#4975 * Add integration and unit tests * Fix lint error * Add changelog entry --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
PR Description
Which issue(s) this PR fixes
Fixes #4975
Notes to the Reviewer
Add an
assets.StoreBuilderto theeventProcessorso it can be passed toprovisionAlertmanagerConfigurationthat needs to fetch k8s secrets and configmaps in order to populate Alertmanager configs.PR Checklist