Merged
Conversation
x1unix
force-pushed
the
x1unix/feat/3174-support-dnssrvnoa
branch
from
1abd942 to
44b3d6f
Compare
thampiotr
reviewed
Dec 9, 2025
| _, addresses, err := srvLookup("", "", addr) | ||
| result := make([]string, 0, len(addresses)) | ||
| for _, a := range addresses { | ||
| result = append(result, a.Target) |
Contributor
There was a problem hiding this comment.
Is there anything in spec about randomizing the order here? for clustering purposes, it may be useful to have the addresses in random order :)
Member
Author
There was a problem hiding this comment.
@thampiotr IIRC spec doesn't mention this, but some DNS servers return items in a random order - this was the case with Consul, and Alloy worked perfectly fine with that during my test run.
Do you know if Loki and Tempo do any explicit randomization?
x1unix
force-pushed
the
x1unix/feat/3174-support-dnssrvnoa
branch
from
44b3d6f to
26c90fa
Compare
Contributor
|
💻 Deploy preview deleted (feat: support DNS SD URLs). |
dehaansa
approved these changes
Dec 11, 2025
Contributor
dehaansa
left a comment
dehaansa
left a comment
There was a problem hiding this comment.
LGTM, though one nit on the changelog.
Co-authored-by: Sam DeHaan <sam.dehaan@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces support of DNS SD URL format for
--cluster.join-addressesflag.Following formats are supported:
dns+hostname.example.comdnssrv+_alloy-memberlist._tcp.service.consuldnssrvnoa+_alloy-memberlist._tcp.service.consulDemo - Alloy cluster using members list from Consul DNS
Which issue(s) this PR fixes
Fixes: #3174
Notes to the Reviewer
PR Checklist