feat: support metadata in Remote Write V2#5045
Merged
Conversation
Contributor
|
💻 Deploy preview available (Support metadata in Remote Write V2): |
kgeckhart
reviewed
Dec 9, 2025
Contributor
kgeckhart
left a comment
kgeckhart
left a comment
There was a problem hiding this comment.
I ran out of time so didn't quite get to check this in depth and will do it tomorrow. Surface level it all makes sense.
kgeckhart
reviewed
Dec 10, 2025
Contributor
kgeckhart
left a comment
kgeckhart
left a comment
There was a problem hiding this comment.
Just a few more minor comments, nice work!
ptodev
force-pushed
the
kgeckhart/metadata-integration-tests-remote_write
branch
from
757c028 to
46d0290
Compare
kgeckhart
approved these changes
Dec 11, 2025
ptodev
force-pushed
the
kgeckhart/metadata-integration-tests-remote_write
branch
from
46d0290 to
0b23768
Compare
Co-authored-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
…ossible. This reduces flakyness and reduce test times.
ptodev
force-pushed
the
kgeckhart/metadata-integration-tests-remote_write
branch
from
0b23768 to
3cffbe5
Compare
ptodev
changed the title
ptodev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding metadata support to
prometheus.remote_writecomponent, but only if Remote Write v2 has been configured.In order for
prometheus.remote_writeto receive metadata,prometheus.scrapemust be configured withhonor_metadata = true.BEGIN_COMMIT_OVERRIDE
feat: add metadata support to
prometheus.remote_writecomponent, but only if Remote Write v2 has been configured. In order forprometheus.remote_writeto receive metadata,prometheus.scrapemust be configured withhonor_metadata = true.END_COMMIT_OVERRIDE