Conversation
Contributor
|
💻 Deploy preview deleted (Encode the behavior into the promtail converter that promtail does internally to limit k8s discovery). |
kgeckhart
approved these changes
Dec 10, 2025
dehaansa
force-pushed
the
promtailconverter-node-filter
branch
from
1e4da1d to
dce39bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Promtail adds a selector to its k8s discovery configs in code, and we did not mimic this logic in Alloy. As the Alloy kubernetes.discovery component needs to be more flexible, this should not be enforced in code, and instead should be clearly done in the promtail conversion.
Which issue(s) this PR fixes
None currently open, but several older like #3953
Notes to the Reviewer
PR Checklist