relabel: default value for source_labels should be nil and not empty slice#5059
Merged
relabel: default value for source_labels should be nil and not empty slice#5059
Conversation
dehaansa
approved these changes
Dec 10, 2025
kalleep
force-pushed
the
kalleep/fix-relabel-defaults
branch
from
c540ded to
3be3b1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Seems like latest prometheus update relabel rules are now validated when with scrape config. When we translate our internal structure we did not generate valid rules for e.g. e.g.
labeldrop. This affects at leastprometheus.operator.*but maybe more?We need to set
source_labelsto nil and not empty slice.Which issue(s) this PR fixes
Fixes: #4992
Notes to the Reviewer
PR Checklist