fix: preserve meta labels in loki.source.podlogs#5097
Merged
Conversation
Contributor
Author
|
FYI @QuentinBisson |
Contributor
|
Oh I did not see this one at all, thank you |
Contributor
Author
No worries I did not see that either. Just wanted to let you know :) |
kalleep
force-pushed
the
kalleep/fix-loki-source-podlogs-meta-labels
branch
from
40e8818 to
72847b0
Compare
blewis12
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
In #4606 the intention was to add a config option for
loki.source.podlogsto preserve meta labels to that they could be used in other components.This do not work because the tailer was stripping all public labels (
__). So we need to propagate this setting and handle it correctly.Which issue(s) this PR fixes
Fixes #5081
Notes to the Reviewer
PR Checklist
BEGIN_COMMIT_OVERRIDE
fix: Preserve meta labels in loki.source.podlogs (#5097)
END_COMMIT_OVERRIDE