Skip to content

feat: Database_observability: support Azure privatelink db name #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristiangreco merged 2 commits into from
Jan 14, 2026
Merged

feat: Database_observability: support Azure privatelink db name #5260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518fa23
feat: Database_observability: support Azure privatelink db name
cristiangreco Jan 14, 2026
f9959bf
Merge branch 'main' into cristian/dbo11y-azure-privatelink
cristiangreco Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/component/database_observability/mysql/collector/connection_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ConnectionInfoName = "connection_info"

var (
rdsRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`)
azureRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.mysql\.database\.azure\.com`)
azureRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.(?:privatelink\.)?mysql\.database\.azure\.com`)
)

type ConnectionInfoArguments struct {
Expand Down
6 changes: 6 additions & 0 deletions internal/component/database_observability/mysql/collector/connection_info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ func TestConnectionInfo(t *testing.T) {
engineVersion: "8.0.32",
expectedMetrics: fmt.Sprintf(baseExpectedMetrics, "products-db", "mysql", "8.0.32", "unknown", "azure", "unknown"),
},
{
name: "Azure privatelink dsn",
dsn: "user:pass@tcp(products-db.privatelink.mysql.database.azure.com:3306)/schema",
engineVersion: "8.0.32",
expectedMetrics: fmt.Sprintf(baseExpectedMetrics, "products-db", "mysql", "8.0.32", "unknown", "azure", "unknown"),
},
}

for _, tc := range testCases {
Expand Down
2 changes: 1 addition & 1 deletion internal/component/database_observability/postgres/collector/connection_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const ConnectionInfoName = "connection_info"

var (
rdsRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`)
azureRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.postgres\.database\.azure\.com`)
azureRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.(?:privatelink\.)?postgres\.database\.azure\.com`)
)

var engineVersionRegex = regexp.MustCompile(`(?P<version>^[1-9]+\.[1-9]+)(?P<suffix>.*)?$`)
Expand Down
6 changes: 6 additions & 0 deletions internal/component/database_observability/postgres/collector/connection_info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ func TestConnectionInfo(t *testing.T) {
engineVersion: "15.4",
expectedMetrics: fmt.Sprintf(baseExpectedMetrics, "products-db", "postgres", "15.4", "unknown", "azure", "unknown"),
},
{
name: "Azure privatelink dsn",
dsn: "postgres://user:pass@products-db.privatelink.postgres.database.azure.com:5432/mydb",
engineVersion: "15.4",
expectedMetrics: fmt.Sprintf(baseExpectedMetrics, "products-db", "postgres", "15.4", "unknown", "azure", "unknown"),
},
}

for _, tc := range testCases {
Expand Down
Loading