fix: Database_observability: fix race in postgres query samples test#5315
Merged
cristiangreco merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
cristiangreco
force-pushed
the
cristian/dbo11y-fix-pg-query-samples-race
branch
3 times, most recently
from
06f5af3 to
6e530b7
Compare
cristiangreco
force-pushed
the
cristian/dbo11y-fix-pg-query-samples-race
branch
from
6e530b7 to
80bc1b5
Compare
fridgepoet
approved these changes
Jan 22, 2026
matthewnolf
approved these changes
Jan 22, 2026
This was referenced Jan 22, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Attempt to fix a race condition in tests. Split out test cases where we expect only error logs into a separate test: this way we can use a different assertion that makes sure all mock queries have been executed.
Pull Request Details
Issue(s) fixed by this Pull Request
n.a.
Notes to the Reviewer
PR Checklist