ci: Allow release note enrichment when "closes" is present#5398
Merged
ci: Allow release note enrichment when "closes" is present#5398
Conversation
jharvey10
commented
Jan 29, 2026
|
|
||
| // commitPattern matches a commit SHA in markdown link format: "([abc1234](https://github.com/.../commit/...))" | ||
| // It captures the short SHA from the link text, regardless of surrounding context. | ||
| var commitPattern = regexp.MustCompile(`\(\[([a-f0-9]{7,40})\]\(https://github\.com/[^)]+\)\)`) |
Contributor
Author
There was a problem hiding this comment.
the main difference is the absence of \s*$
jharvey10
changed the title
dehaansa
approved these changes
Jan 29, 2026
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
An interesting thing I discovered with release please is that if a commit has a reference to a closed issue, this will be called out in the changelog 🎉 For example: ``` * Invalid handling of id in foreach when using discovery components (\#5322) (61fe184), closes \#5297 ``` The only problem is this breaks the way I wrote the regex for the release not enrichment script. This PR fixes that. (cherry picked from commit 8cfe2f1)
jharvey10
added a commit
that referenced
this pull request
Jan 29, 2026
…#5400) ## Backport of #5398 This PR backports #5398 to release/v1.13. ### Original PR Author @jharvey10 ### Description An interesting thing I discovered with release please is that if a commit has a reference to a closed issue, this will be called out in the changelog 🎉 For example: ``` * Invalid handling of id in foreach when using discovery components (#5322) (61fe184), closes #5297 ``` The only problem is this breaks the way I wrote the regex for the release not enrichment script. This PR fixes that. --- *This backport was created automatically.* Co-authored-by: Joe Harvey <51208233+jharvey10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interesting thing I discovered with release please is that if a commit has a reference to a closed issue, this will be called out in the changelog 🎉
For example:
The only problem is this breaks the way I wrote the regex for the release not enrichment script. This PR fixes that.