fix(loki.source.file): Make sure position is recorded when component exit#5412
Merged
fix(loki.source.file): Make sure position is recorded when component exit#5412
Conversation
ptodev
approved these changes
Feb 2, 2026
Contributor
|
Contributor
|
kalleep
added a commit
that referenced
this pull request
Feb 2, 2026
…exit (#5412) We only update position for a file after some time have passed and when tailer exist. But then we stopped position file before we stopped all tailers so if a file was ingested fast we never stored last read offset. To fix this we need to stop position after all trailers have been stopped and we need to set lastUpdatedPosition to the start position. <!-- Add any relevant notes for the reviewers and testers of this PR. --> <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [ ] Tests updated - [ ] Config converters updated (cherry picked from commit 79e138d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
We only update position for a file after some time have passed and when tailer exist. But then we stopped position file before we stopped all tailers so if a file was ingested fast we never stored last read offset.
To fix this we need to stop position after all trailers have been stopped and we need to set lastUpdatedPosition to the start position.
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist