fix(database_observability.mysql): Skip wait events with NULL timer_wait#5478
Merged
cristiangreco merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
Do not log wait events with NULL timer_wait (currently logged as "0ms" duration), as they do not provide meaningful information.
cristiangreco
changed the title
NULL timer_wait
matthewnolf
approved these changes
Feb 12, 2026
Draft
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
…_wait (#5478) ### Brief description of Pull Request Do not log wait events with NULL timer_wait (currently logged as "0ms" duration), as they do not provide meaningful information. ### Pull Request Details Avoid logs like ``` wait_event_name="wait/io/socket/sql/client_connection" wait_object_type="SOCKET" wait_time="0.000000ms" sql_text="COMMIT" ``` ### Issue(s) fixed by this Pull Request <!-- Uncomment the following line and fill in an issue number if you want a GitHub issue to be closed automatically when this PR gets merged. --> <!-- Fixes #issue_id --> ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated (cherry picked from commit 48750e5)
3 tasks
cristiangreco
added a commit
that referenced
this pull request
Feb 12, 2026
…_wait [backport] (#5521) ## Backport of #5478 This PR backports #5478 to release/v1.13. ### Original PR Author @cristiangreco ### Description ### Brief description of Pull Request Do not log wait events with NULL timer_wait (currently logged as "0ms" duration), as they do not provide meaningful information. ### Pull Request Details Avoid logs like ``` wait_event_name="wait/io/socket/sql/client_connection" wait_object_type="SOCKET" wait_time="0.000000ms" sql_text="COMMIT" ``` ### Issue(s) fixed by this Pull Request <!-- Uncomment the following line and fill in an issue number if you want a GitHub issue to be closed automatically when this PR gets merged. --> <!-- Fixes #issue_id --> ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated --- *This backport was created automatically.* Co-authored-by: Cristian Greco <cristian@regolo.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Do not log wait events with NULL timer_wait (currently logged as "0ms" duration), as they do not provide meaningful information.
Pull Request Details
Avoid logs like
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist