Skip to content

fix(prometheus.receive_http): Bump prometheus patch for bugfix#5505

Merged
kgeckhart merged 1 commit intomainfrom
kgeckhart/bump-prometheus-patch-for-bugfix
Feb 12, 2026
Merged

fix(prometheus.receive_http): Bump prometheus patch for bugfix#5505
kgeckhart merged 1 commit intomainfrom
kgeckhart/bump-prometheus-patch-for-bugfix

Conversation

@kgeckhart
Copy link
Contributor

Brief description of Pull Request

Bump to prometheus patch release to pull in the fix for prometheus/prometheus#17659 which would impact prometheus.receive_http which uses the upstream remote.NewWriteHandler which was impacted by prometheus/client_golang#1927.

Issue(s) fixed by this Pull Request

Resolves: #5471

Notes to the Reviewer

I didn't add a test because it's a rather low level implementation details about returning response stats vs not returning response stats. I'm open to adding one though.

@kgeckhart kgeckhart requested a review from a team as a code owner February 11, 2026 19:40
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

🔍 Dependency Review

github.com/prometheus/client_golang/exp v0.0.0-20250914183048-a974e0d45e0a -> v0.0.0-20251212205219-7ba246a648ca — ⚠️ Needs Review
  • Scope: This is the experimental module of Prometheus client_golang. It is explicitly not API-stable and uses pseudo-versions (commit SHAs). There are no tagged releases or formal changelogs for these ranges.
  • Evidence:

What to check in your codebase

  • Because this module is required directly in your root go.mod, it is very likely imported. Identify usages:
    grep -R --line-number --no-messages 'github.com/prometheus/client_golang/exp' .
    
  • Common areas of usage in exp historically include experimental instrumentation (e.g., bridges, handlers, collectors). Verify constructors, option structs, and package paths for any changed/removed symbols.

Recommended process

  1. Attempt a clean build and tests to surface compile errors:
    go clean -modcache
    go mod tidy
    go build ./...
    go test ./...
    
  2. For any compile errors, open the diff above and the package docs at the new commit to map symbol/constructor/option changes.

Notes on code changes

  • There is no published changelog for the exp module between these two SHAs. Without concrete changes referenced by the upstream repository, specific edits cannot be enumerated here.
  • If compilation breaks due to renamed constructors or options, update call sites to the new names as indicated by the compiler errors and the upstream docs at the target commit.

If you need to defer risk

  • Pin back to the previous commit until manual adaptation is complete:
    go get github.com/prometheus/client_golang/exp@a974e0d45e0a
    
github.com/prometheus/prometheus v0.308.0 -> v0.308.1 — ⚠️ Needs Review
  • Scope: Patch bump within the same minor of Prometheus’ monorepo module. Typically includes bug fixes; API breakage is unlikely but Prometheus’ repo is large and not all internal packages are API-stable.
  • Evidence:

What to check in your codebase

  • Identify which Prometheus packages you import (e.g., promql, tsdb, scrape, rules, discovery, model):
    grep -R --line-number --no-messages 'github.com/prometheus/prometheus' .
    
  • Build and test to confirm no API shifts in the imported packages:
    go mod tidy
    go build ./...
    go test ./...
    

Expected code changes

  • None identified from available public signals for this patch upgrade.
  • If compiler errors arise, they will most likely be minor method or type adjustments in internal packages. Update call sites per the compiler guidance.

Notes

  • No other dependency changes were detected in the provided go.mod diffs.
  • For both upgrades, please rely on a full build/test cycle to surface any symbol or package-path changes, as there are no explicit upstream release notes covering these exact ranges.

@kgeckhart kgeckhart force-pushed the kgeckhart/bump-prometheus-patch-for-bugfix branch from ec38261 to 7101518 Compare February 11, 2026 20:20
Copy link
Contributor

@kalleep kalleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kgeckhart kgeckhart merged commit b7a1d05 into main Feb 12, 2026
48 checks passed
@kgeckhart kgeckhart deleted the kgeckhart/bump-prometheus-patch-for-bugfix branch February 12, 2026 13:47
@grafana-alloybot grafana-alloybot bot mentioned this pull request Feb 12, 2026
grafana-alloybot bot pushed a commit that referenced this pull request Feb 12, 2026
### Brief description of Pull Request

Bump to prometheus patch release to pull in the fix for
prometheus/prometheus#17659 which would impact
`prometheus.receive_http` which uses the upstream
`remote.NewWriteHandler` which was impacted by
prometheus/client_golang#1927.

### Issue(s) fixed by this Pull Request

Resolves: #5471

### Notes to the Reviewer

I didn't add a test because it's a rather low level implementation
details about returning response stats vs not returning response stats.
I'm open to adding one though.

(cherry picked from commit b7a1d05)
kgeckhart added a commit that referenced this pull request Feb 12, 2026
…ort] (#5516)

## Backport of #5505

This PR backports #5505 to release/v1.13.

### Original PR Author
@kgeckhart

### Description
### Brief description of Pull Request

Bump to prometheus patch release to pull in the fix for
prometheus/prometheus#17659 which would impact
`prometheus.receive_http` which uses the upstream
`remote.NewWriteHandler` which was impacted by
prometheus/client_golang#1927.

### Issue(s) fixed by this Pull Request

Resolves: #5471

### Notes to the Reviewer

I didn't add a test because it's a rather low level implementation
details about returning response stats vs not returning response stats.
I'm open to adding one though.

---
*This backport was created automatically.*

Co-authored-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"we got 2xx status code from the Receiver yet statistics indicate some data was not written; investigation needed"

2 participants