fix(loki.source.file): Close file if we cannot find encoding#5528
Merged
fix(loki.source.file): Close file if we cannot find encoding#5528
Conversation
blewis12
approved these changes
Feb 13, 2026
Contributor
Author
No but it got me to review the paths we are opening files |
Draft
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
### Pull Request Details Noticed that we do not close file if we cannot get encoding. Review all other paths and we close file properly. I really wish go had something like [errdefer like zig does](https://ziglang.org/documentation/master/#errdefer). ### Issue(s) fixed by this Pull Request <!-- Uncomment the following line and fill in an issue number if you want a GitHub issue to be closed automatically when this PR gets merged. --> <!-- Fixes #issue_id --> ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [ ] Tests updated - [ ] Config converters updated (cherry picked from commit 56bcb26)
3 tasks
kalleep
added a commit
that referenced
this pull request
Feb 13, 2026
…t] (#5531) ## Backport of #5528 This PR backports #5528 to release/v1.13. ### Original PR Author @kalleep ### Description ### Pull Request Details Noticed that we do not close file if we cannot get encoding. Review all other paths and we close file properly. I really wish go had something like [errdefer like zig does](https://ziglang.org/documentation/master/#errdefer). ### Issue(s) fixed by this Pull Request <!-- Uncomment the following line and fill in an issue number if you want a GitHub issue to be closed automatically when this PR gets merged. --> <!-- Fixes #issue_id --> ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [ ] Tests updated - [ ] Config converters updated --- *This backport was created automatically.* Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
matt-gp
pushed a commit
to matt-gp/alloy
that referenced
this pull request
Feb 13, 2026
…#5528) ### Pull Request Details Noticed that we do not close file if we cannot get encoding. Review all other paths and we close file properly. I really wish go had something like [errdefer like zig does](https://ziglang.org/documentation/master/#errdefer). ### Issue(s) fixed by this Pull Request <!-- Uncomment the following line and fill in an issue number if you want a GitHub issue to be closed automatically when this PR gets merged. --> <!-- Fixes #issue_id --> ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [ ] Tests updated - [ ] Config converters updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Noticed that we do not close file if we cannot get encoding. Review all other paths and we close file properly.
I really wish go had something like errdefer like zig does.
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist