Skip to content

feat/cleanup#415

Merged
benjie merged 11 commits into
graphile:mainfrom
christophemacabiau:feat/cleanup
Jan 15, 2024
Merged

feat/cleanup#415
benjie merged 11 commits into
graphile:mainfrom
christophemacabiau:feat/cleanup

Conversation

@christophemacabiau
Copy link
Copy Markdown
Contributor

@christophemacabiau christophemacabiau commented Dec 19, 2023 •
edited
Loading

Description

Allow users to clean the private tables
issue #412

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.

@christophemacabiau christophemacabiau changed the title Feat/cleanup feat/cleanup Dec 19, 2023
@christophemacabiau christophemacabiau marked this pull request as ready for review December 20, 2023 10:01
@christophemacabiau
Copy link
Copy Markdown
Contributor Author

christophemacabiau commented Jan 8, 2024

Hi @benjie
Best wishes!
Have you had time to check out the PR? Do you have any comments?

benjie
benjie previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this; sorry it's taken me a while to get around to working on it, it has been hectic!

benjie
benjie previously approved these changes Jan 15, 2024
View reviewed changes
@benjie benjie merged commit 0d71581 into graphile:main Jan 15, 2024
This was referenced Jan 17, 2024
Merged
Closed
@christophemacabiau
Copy link
Copy Markdown
Contributor Author

christophemacabiau commented Mar 6, 2024

Hi @benjie
I think there was a bug in the documentation of my PR, the call to cleanup should be:

await workerUtils.cleanup({tasks: [
  "DELETE_PERMAFAILED_JOBS",
  "GC_TASK_IDENTIFIERS",
  "GC_JOB_QUEUES",
])};

Do you want a PR?

@benjie
Copy link
Copy Markdown
Member

benjie commented Mar 7, 2024

Oh; good spot! Yes please :)

@benjie benjie mentioned this pull request Mar 11, 2024
Merged
@benjie
Copy link
Copy Markdown
Member

benjie commented Mar 11, 2024

Addressed in #447

@christophemacabiau christophemacabiau mentioned this pull request Apr 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjie benjie benjie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christophemacabiau @benjie