chore: convert repo into a yarn workspaces monorepo and add sdk package by tmigone · Pull Request #888 · graphprotocol/contracts

tmigone · 2023-11-28T21:17:08Z

⚠️ You'll need Yarn v4 for this!! Follow readme instructions.

Changes

Converted repo into a yarn workspaces monorepo
Moved contracts files into contracts package
Updated github workflows
Added sdk package from commit 7d238087f93305b263f2105487127139cf2ac71c

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

openzeppelin-code · 2023-11-28T21:25:31Z

chore: convert repo into a yarn workspaces monorepo and add sdk package

Generated at commit: 2db4c7e9cb0e4e9b262d031578ee218a5dea93c0

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 18 32 52
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

socket-security · 2023-11-28T21:26:18Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
hardhat-secure-accounts	0.0.6	None	`+27`	58.4 MB	tmigone
@graphprotocol/common-ts	2.0.9	None	`+24`	14.6 MB	fordn
eslint-config-prettier	9.1.0	None	`+18`	5.9 MB	lydell
@types/inquirer	8.2.10	None	`+1`	3.89 MB	types
@types/mocha	10.0.6	None	`+0`	95.6 kB	types
@types/chai	4.3.11	None	`+0`	76.8 kB	types
@types/yargs	16.0.9	None	`+0`	53 kB	types
eslint-plugin-no-only-tests	3.1.0	None	`+0`	9.54 kB	levibuzolic
@types/lodash	4.14.202	None	`+0`	862 kB	types
@types/debug	4.1.12	None	`+0`	6.45 kB	types
@typescript-eslint/eslint-plugin	6.14.0	None	`+28`	42.6 MB	jameshenry
@typescript-eslint/parser	6.14.0	None	`+24`	39.6 MB	jameshenry
@types/node	20.10.4	None	`+0`	3.93 MB	types
eslint-plugin-prettier	5.0.1	None	`+42`	14.9 MB	jounqin
ethers	5.7.0	None	`+4`	12.1 MB	ricmoo
eslint	8.55.0	None	`+34`	8.73 MB	eslintbot
prettier	3.1.1	filesystem, environment	`+0`	8.42 MB	prettier-bot
typescript	5.3.3	None	`+0`	32 MB	typescript-bot
husky	7.0.4...8.0.3	None	`+0/-0`	6.44 kB	typicode
@commitlint/cli	13.2.1...18.4.3	None	`+36/-25`	38.9 MB	escapedcat
prettier-plugin-solidity	1.1.3...1.0.0-beta.19	filesystem	`+4/-1`	6.64 MB	janther
@commitlint/config-conventional	13.2.0...18.4.3	None	`+1/-2`	25.7 kB	escapedcat

🚮 Removed packages: @types/node@20.9.0, @types/yargs@16.0.8, @urql/core@2.6.1

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

pcarranzav · 2023-12-08T17:32:37Z

-        override
-        onlyGovernor
-    {
+    function setMinimumCurationDeposit(


hmm is it possible that the linter config broke with the move? seems it's changing everything to a different format, but the .prettierrc.json hasn't changed, so maybe it's not picking it up anymore?

mmm looks like you are right. fixing.

Ok found the root cause. When converting to a monorepo I deleted yarn lock file to bump dependencies, it looks like newer versions of our linting tools just have different rules.

If you delete yarn.lock on the main branch and do a fresh install then lint the code it will output the code linted as in this PR.

So I'm inclined to keep this as is.

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

…ormatting Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

* chore: wip changes to integrate with sdk Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * fix: clean up Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: remove test lib helper, replace with sdk Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: use sdk for test libs Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * feat: tests and e2e tests passing Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: wip decouple and delete cli Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * feat(sdk): complete sdk integrationx Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * test: fix chai matchers Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * 5.3.1 * chore: bump sdk, remove gre ci tests Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * test: fix coverage tes Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: bump sdk version Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * 5.3.2 * fix: support e2e tests Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: rename cli folder Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * test: disable interval mining in hardhat network Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: delete commented out import Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: convert repo into a yarn workspaces monorepo and add sdk package (#888) * chore: convert repo into a yarn workspaces monorepo Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: add sdk Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: fix cross reference dependencies and add readme Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: fix setup action Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: use yarn v4 Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: add missing property to setup action Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: add more missing properties Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: refactor corepack enable Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: run for all branches and prs Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: fix coverage file path Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * ci: add workflow dispatch trigger Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: trigger ci Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: update README Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * test: fix failing tests Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: minor nits Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: fixup prettier config Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: roll back prettier-plugin-solidity to old version to avoid reformatting Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * chore: bump packages versions and add publish ci action Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * docs: update readme with versioning and publishing instructions Signed-off-by: Tomás Migone <tomas@edgeandnode.com> --------- Signed-off-by: Tomás Migone <tomas@edgeandnode.com> * fix: change localhost for 127.0.0.1 to avoid node v17+ issues Signed-off-by: Tomás Migone <tomas@edgeandnode.com> --------- Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: convert repo into a yarn workspaces monorepo

c31b1b1

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

tmigone added 11 commits December 1, 2023 11:03

chore: add sdk

2108615

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: fix cross reference dependencies and add readme

f6c0572

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: fix setup action

1f60a3e

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: use yarn v4

a811e55

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: add missing property to setup action

f581f0d

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: add more missing properties

d7c401f

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: refactor corepack enable

e662730

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: run for all branches and prs

fd0f985

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: fix coverage file path

0bfe0ab

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

ci: add workflow dispatch trigger

7ebeaf8

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: trigger ci

e1c4cab

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

tmigone requested review from Maikol, abarmat and pcarranzav December 1, 2023 20:53

tmigone marked this pull request as ready for review December 1, 2023 20:54

tmigone changed the title ~~chore: convert repo into a yarn workspaces monorepo~~ chore: convert repo into a yarn workspaces monorepo and add sdk package Dec 1, 2023

chore: update README

bf542ad

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

pcarranzav reviewed Dec 8, 2023

View reviewed changes

Comment thread packages/contracts/package.json Outdated

Comment thread packages/sdk/addresses.json Outdated

tmigone added 4 commits December 11, 2023 16:10

Merge branch 'tmigone/sdk' into tmigone/monorepo

c579156

test: fix failing tests

9cdbe01

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: minor nits

42a5d7a

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: fixup prettier config

3af9465

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

Maikol approved these changes Dec 12, 2023

View reviewed changes

tmigone added 3 commits December 12, 2023 11:41

chore: roll back prettier-plugin-solidity to old version to avoid ref…

4f2c311

…ormatting Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

chore: bump packages versions and add publish ci action

b14bbdf

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

docs: update readme with versioning and publishing instructions

2db4c7e

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

pcarranzav approved these changes Dec 13, 2023

View reviewed changes

tmigone merged commit 93a2a46 into tmigone/sdk Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: convert repo into a yarn workspaces monorepo and add sdk package#888

chore: convert repo into a yarn workspaces monorepo and add sdk package#888
tmigone merged 20 commits into
tmigone/sdkfrom
tmigone/monorepo

tmigone commented Nov 28, 2023 •

edited

Loading

Uh oh!

openzeppelin-code Bot commented Nov 28, 2023 •

edited

Loading

Uh oh!

socket-security Bot commented Nov 28, 2023 •

edited

Loading

Uh oh!

Uh oh!

pcarranzav Dec 8, 2023

Uh oh!

tmigone Dec 11, 2023

Uh oh!

tmigone Dec 11, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tmigone commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openzeppelin-code Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

chore: convert repo into a yarn workspaces monorepo and add sdk package

🚨 Report Summary

Uh oh!

socket-security Bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pcarranzav Dec 8, 2023

Choose a reason for hiding this comment

Uh oh!

tmigone Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

tmigone Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tmigone commented Nov 28, 2023 •

edited

Loading

openzeppelin-code Bot commented Nov 28, 2023 •

edited

Loading

socket-security Bot commented Nov 28, 2023 •

edited

Loading