fix: url issue for path string for ui tools (playground, voyager, graphiql) by pobisw · Pull Request #195 · graphql-dotnet/server

pobisw · 2019-01-12T13:43:16Z

fixes #184

…hema_fetch' of https://github.com/pobisw/server into pobisw/Fix_playground_graphiql_path_string_issue_for_schema_fetch

pobisw · 2019-01-12T13:51:06Z

@pekkah @BenjaBobs Can you please take a look at this PR
added the fix for all the 3 UI tool

pobisw · 2019-01-14T15:31:33Z

@joemcbride @pekkah please review

pobisw · 2019-01-16T10:26:39Z

@pekkah can you please look at this ? this issue is blocking our development

joemcbride

I mentioned this in the other issue, though this seems to make it so you can’t have your GraphQL endpoint at a different root url, which is a valid scenario. Is there something blocking you from setting that url to the path that you need?

pobisw · 2019-01-17T14:13:24Z

I mentioned this in the other issue, though this seems to make it so you can’t have your GraphQL endpoint at a different root url, which is a valid scenario. Is there something blocking you from setting that url to the path that you need?

I have replied in the other issue, restating it here, we have multiple int and dev root urls, so we cant set it to a fixed value

sungam3r · 2020-11-11T21:08:35Z

@pobisw Thanks for this PR. I will try to review it if you resolve conflicts. Also, could you not change the indentation in the cshtml files so as not to complicate the review?

Shane32 · 2020-11-11T21:34:44Z

@pobisw Thanks for this PR. I will try to review it if you resolve conflicts. Also, could you not change the indentation in the cshtml files so as not to complicate the review?

Just FYI, you can turn off whitespace comparison on github's website, @sungam3r

Shane32 · 2020-11-11T21:35:07Z

sungam3r · 2020-11-12T06:46:48Z

OK

pobisw · 2021-03-25T07:59:26Z

just saw the comments, will make the changes

Shane32 · 2021-12-30T12:47:50Z

+            return currentPathName;
+        }
+
+        var strippedCurrentPathName = stripGraphQLUiEndPointFromPathName("@Model.GraphiQLPath");


This injected variable appears to be encoded for HTML instead of for Javascript - correct? Or does Razor detect that it's within a <script> tag and encode it differently?

Razor? No Razor here 🤔 .

cshtml are razor pages and @Model.GraphiQLPath is razor injecting a variable. By default it will format variables with html encoding. So I always use JavaScript encoding as shown below when injecting a variable into a script tag like this. Or encode it as json and then inject it. Or put it into a html tag and read the tag.

cshtml are razor pages

Yes but ... no Razor engine/stuff/handlers/compilers here.

Just good old string.Replace.

Ok I see. Then we should modify the string.Replace encode to javascript-encode the variables for use on the page. Probably not a critical fix as the url is controlled by the setup code, not user input.

Shane32 · 2021-12-30T12:49:50Z

+
+        function stripGraphQLUiEndPointFromPathName(graphQlUiEndpoint) {
+            var currentPathName = window.location.pathname;
+            var regex = new RegExp(graphQlUiEndpoint + "\/*");


Here the path name from the model variable is passed directly into a regular expression without encoding. Also seems wrong. Maybe this should not be using regexp at all and just perform a simple replace...

sungam3r · 2021-12-30T19:56:27Z

just saw the comments, will make the changes

@pobisw Thanks for the fix. The main thing here is to resolve conflicts, after which we can continue review.

Shane32 · 2022-07-11T13:47:46Z

Replaced by #853

poojaNN and others added 6 commits January 12, 2019 19:02

code changes for fixing url issue

113cd60

removing package.json

97ef828

Merge branch 'pobisw/Fix_playground_graphiql_path_string_issue_for_sc…

d434e7d

…hema_fetch' of https://github.com/pobisw/server into pobisw/Fix_playground_graphiql_path_string_issue_for_schema_fetch

removing package.json

fef8cde

removing package.json

2d0c724

Update package-lock.json

947ea69

pobisw mentioned this pull request Jan 12, 2019

Fixing path string issue for playground schema fetch #185

Closed

fix

baaf028

pobisw changed the title ~~code changes for fixing url issue~~ fix: url issue for path string for ui tools (playground, voyager, graphiql) Jan 16, 2019

joemcbride requested changes Jan 16, 2019

View reviewed changes

Comment thread src/Ui.GraphiQL/Internal/graphiql.cshtml

poojaNN added 3 commits January 17, 2019 17:12

adding back code removed mistakenly

0113ca9

adding back code removed mistakenly

a78cdca

adding back code removed mistakenly

b43e7fb

sungam3r added bugfix Pull request that fixes a bug needs review labels Feb 24, 2020

Shane32 changed the base branch from develop to master October 26, 2020 23:32

sungam3r linked an issue Nov 11, 2020 that may be closed by this pull request

playground is loading schema directly from the baseurl, not considering the string path after first slash #184

Closed

sungam3r added the needs confirmation The problem is most likely resolved and requires verification by the author label Nov 11, 2020

sungam3r added this to the v5.2 milestone Nov 23, 2021

Shane32 mentioned this pull request Dec 29, 2021

Release v5.2 #688

Closed

3 tasks

Shane32 reviewed Dec 30, 2021

View reviewed changes

sungam3r removed this from the v5.2 milestone Jan 1, 2022

Shane32 mentioned this pull request Apr 14, 2022

Change to file-scoped namespaces #773

Merged

Shane32 mentioned this pull request Jul 7, 2022

Support absolute and relative URLs #853

Merged

3 tasks

Shane32 closed this Jul 11, 2022

sungam3r removed needs review needs confirmation The problem is most likely resolved and requires verification by the author labels Jul 11, 2022

Conversation

pobisw commented Jan 12, 2019 • edited by sungam3r Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pobisw commented Jan 12, 2019

Uh oh!

pobisw commented Jan 14, 2019

Uh oh!

pobisw commented Jan 16, 2019

Uh oh!

joemcbride left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pobisw commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sungam3r commented Nov 11, 2020

Uh oh!

Shane32 commented Nov 11, 2020

Uh oh!

Shane32 commented Nov 11, 2020

Uh oh!

sungam3r commented Nov 12, 2020

Uh oh!

pobisw commented Mar 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sungam3r commented Dec 30, 2021

Uh oh!

Shane32 commented Jul 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pobisw commented Jan 12, 2019 •

edited by sungam3r

Loading

pobisw commented Jan 17, 2019 •

edited

Loading