Get default type of hybrid_property from type annotation

[conao3]

Fix below TODO comment.

# TODO The default type should be dependent on the type of the property propety.

Examines the return type of the function of hybrid_property and converts it to the default graphene type.

[conao3]

In modern python, instead of a class, it contains class name

This commit message is wrong. The truth is,

Under `from __future__ import annotations`, instead of a class, it contains class name

[erikwrede]

I just looked at your PR, I think it's a useful change!

Is there any reason you're selecting the corresponding Graphene Types using a switch/case statement instead of adapting the annotation-based system that is used to register SQLAlchemy types? (@convert_sqlalchemy_type.register(JSONType))

I think creating an annotation for the hybrid properties (e.g. something like @convert_sqlalchemy_type.register_hybrid(Type) ) would allow for more flexibility, and is IMO the preferred option over statically converting the base types, since it would allow users to add their own support for types like Tuples etc until we include them. What do you think?

[erikwrede]

See my comment in the PR

[flipbit03]

I need this feature, so I picked it up to try to finish the work.

Just as a heads up, I tried to use the actual @singledispatch mechanism and it is not a very good fit, since we are using actual types from a type annotation, and not values. So the types inside a type annotation usually descend from the base type, so @singledispatch fails to match anything in a meaningful way 😢

I'm trying to code an approach similar to that where we can decorate functions and switch based on value or on some kind of matcher function, so it will basically become a glorified (but as you said, customizable by the end user in a very flexible way) switch statement. I foresee we will still need some kind of escape hatch using the 'default' (no match) function to analyze deeper types like List[T] and things like that.

[erikwrede]

Let me know what you come up with! 😃

[flipbit03]

I will, thank you 🙏 I'll open a new Pull Request for #333 from my own fork as soon as I have the basics working.

[conao3]

I want to finish this work. I will work on this PR tomorrow, so can it wait?

[conao3]

I am branching by case statement because it returning the corresponding Graphene type in a class of type type obtained by __annotations__.
functools.singledispatch is a way to achieve polymorphism by instance type, but I don't know at this time how to achieve polymorphism by the class itself.

[flipbit03]

Indeed, the standard library's singledispatch approach is inadequate for what we want. I provided a solution using a different type of matching but leaving the comfort/developer a @singledispatch-like experience provides.

I finished the work I intended and opened a pull request, mentioning this issue in it, looking forward for the review.

[erikwrede]

Thanks again for initiating this @conao3!

[conao3]

Thank you, too!