Skip to content

Fix BigInt export#1456

Merged
erikwrede merged 1 commit into
graphql-python:masterfrom
erikwrede:master
Aug 28, 2022
Merged

Fix BigInt export#1456
erikwrede merged 1 commit into
graphql-python:masterfrom
erikwrede:master

Conversation

@erikwrede
Copy link
Copy Markdown
Member

Fixes #1436

@erikwrede
Copy link
Copy Markdown
Member Author

@ulgens 🙂 👋

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2022

Codecov Report

Merging #1456 (ae7fb56) into master (355601b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          49       49           
  Lines        1582     1582           
=======================================
  Hits         1510     1510           
  Misses         72       72           
Impacted Files Coverage Δ
graphene/__init__.py 100.00% <ø> (ø)
graphene/types/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ulgens
Copy link
Copy Markdown
Contributor

ulgens commented Aug 28, 2022

@erikwrede The change looks fine. Are we testing this stuff anywhere? If so, can you please update the related tests? Thank you.

@erikwrede
Copy link
Copy Markdown
Member Author

Thank you!
I haven't found any relevant test for exports. Might be a good idea to add a test for that in a future PR!

@erikwrede erikwrede merged commit 35c281a into graphql-python:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigInt type is not exposed on the root level

2 participants