fix: Support making Relay edges node NonNull (#968)#1493
Conversation
7588fe7 to
c8c7b68
Compare
Codecov ReportBase: 95.98% // Head: 95.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 95.98% 95.99% +0.01%
==========================================
Files 51 51
Lines 1742 1747 +5
==========================================
+ Hits 1672 1677 +5
Misses 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erikwrede
left a comment
There was a problem hiding this comment.
Thank your for taking the time to put this together! This will be useful for everyone using codegen until graphql/graphql-spec#867 is merged into the GQL-Spec.
Can you please merge the new tests into the existing connection tests? It will be easier to find that way, as issue tests usually refer to specific bugs, but this is a feature that belongs to the core implementation.
|
This was superseded by #1504 and is released in 3.3.0 😊 |
Support pointing edge and edge node as
NonNullwhen using Relay ConnectionsMain issue: #968
Related issues: mcabrams/doppelganger#64, graphql-python/graphene-sqlalchemy#310