Skip to content

remove aniso8601, mock, iso8601#1548

Merged
erikwrede merged 3 commits into
graphql-python:masterfrom
dulmandakh:remove-aniso8601
Jun 13, 2024
Merged

remove aniso8601, mock, iso8601#1548
erikwrede merged 3 commits into
graphql-python:masterfrom
dulmandakh:remove-aniso8601

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented May 15, 2024

Python 3.7 added fromisoformat functionality, so we can remove aniso8601. There are test cases for it, and all are passing..

Removing mock, because the documentation states below, so we don't need it.

mock is now part of the Python standard library, available as [unittest.mock (https://docs.python.org/dev/library/unittest.mock.html) in Python 3.3 onwards.

@dulmandakh
Copy link
Copy Markdown
Contributor Author

@syrusakbary please review and merge.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (5fb7b54) to head (dedb1f0).
Report is 6 commits behind head on master.

Current head dedb1f0 differs from pull request most recent head 3e588be

Please upload reports for the commit 3e588be to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   96.01%   96.11%   +0.10%     
==========================================
  Files          51       51              
  Lines        1755     1751       -4     
==========================================
- Hits         1685     1683       -2     
+ Misses         70       68       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulmandakh dulmandakh changed the title remove aniso8601 remove aniso8601, mock, iso8601 May 19, 2024
@erikwrede erikwrede merged commit 17d09c8 into graphql-python:master Jun 13, 2024
@dulmandakh dulmandakh deleted the remove-aniso8601 branch June 24, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants