Rename resolve_type method#775
Conversation
|
I like this, however, let's make sure we write this down as a breaking change on the release, so people are aware the name has to be changed from |
|
Any update on this? |
mvanlonden
left a comment
There was a problem hiding this comment.
Approving but wait until ready for 3.0 release, should be merged alongside #738
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
For completeness the decision was taken to not make this change for the following reasons:
class MyInterface(Interface):
type_ = String(name="type")
def resolve_type_(_, info):
return "foo"
|
Fixes #50