Add support for Request<T> where T is a type that implements hyper::body::Body trait#1263
Conversation
Request<T> where T is a type that implements hyper::body::Body trait
|
CI Checks seem to fail and this is weird since the issues arise from the Any pointers? |
LegNeato
left a comment
There was a problem hiding this comment.
Thank you for the PR, sorry for the slow response! Are there backward compat considerations here? I see you have a default type but I am not sure. Also, can you add a test so we can be sure this doesn't regress?
Thanks for checking in. To answer your concerns..
Yes, this PR is fully backward compatible. How do we know? There's a test already included here and it passes with no need for further configuration.
Yes I can add a test for custom |
|
@elcharitas @LegNeato I'll look into it too in the next few working days. |
tyranron
left a comment
There was a problem hiding this comment.
@elcharitas I've somewhat relaxed trait bounds. Anything else seems fine. Thanks! 🍻
Should resolve #1102