ArrayAdapter throws OutOfBoundsException when empty#15
Merged
Conversation
sjparkinson
force-pushed
the
array-adapter-out-of-bounds
branch
from
468c343 to
1fa3ec4
Compare
sjparkinson
force-pushed
the
array-adapter-out-of-bounds
branch
from
1fa3ec4 to
e56aa22
Compare
sjparkinson
force-pushed
the
array-adapter-out-of-bounds
branch
from
e56aa22 to
4cb669f
Compare
sjparkinson
force-pushed
the
master
branch
2 times, most recently
from
d626d09 to
97cab30
Compare
sjparkinson
force-pushed
the
array-adapter-out-of-bounds
branch
2 times, most recently
from
a719363 to
f67df51
Compare
sjparkinson
force-pushed
the
array-adapter-out-of-bounds
branch
from
f67df51 to
42e8b07
Compare
jakewright
added a commit
that referenced
this pull request
Aug 21, 2015
ArrayAdapter throws OutOfBoundsException when empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this case when implementing #14.
Before defaulting the
$queueproperty to an empty array the following error occurred:Now we get an
OutOfBoundsExceptionfrom theforeachcall inAbstractAcknowledgementHandler.Apparently
LimitIteratoris throwing the exception, you can see the source in hhvm: https://github.com/facebook/hhvm/blob/master/hphp/system/php/spl/iterators/LimitIterator.php#L106-L110