PoC for preloading responsive images for blocks#2322
Draft
Osong-Michael wants to merge 1 commit intomainfrom
Draft
PoC for preloading responsive images for blocks#2322Osong-Michael wants to merge 1 commit intomainfrom
Osong-Michael wants to merge 1 commit intomainfrom
Conversation
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 15, 2024
/unhold b99353a7-ba97-43e8-84f9-0ef937b31f73
Contributor
Test instance is ready 🚀🌑 umbriel | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.15 09:41:10 |
c0a0224 to
f887d74
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jan 29, 2025
/unhold 89d298db-1b8f-44a6-a8ee-2a8eaaa03967
f887d74 to
ee74b93
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Feb 3, 2025
/unhold ccbbdb1d-8116-4c32-8ce4-25f20c250135
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Feb 3, 2025
/unhold 4d207b46-9169-419c-8ce7-a8c3a1e7e5bb
- Testing out the functionality using the Carousel Block
ee74b93 to
8c5487f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: PoC for Preloading big images (eg. Carousel Header, Page Header pattern) while using imagesrcset.
Some implementations propose using
<link rel="preload" as="image" href="images/example-medium.jpg" media="(max-width: 1023px)">, while others suggest replacing themediawith asizesattribute instead.Testing
If you disable caching on the Network tab and enable 3G, then you reload the page there are two visible scenarios
This implementation is good for blocks or scenarios where we control what images are being displayed.