Skip to content

New API#30

Merged
gregziegan merged 26 commits into
masterfrom
new-api
Aug 30, 2016
Merged

New API#30
gregziegan merged 26 commits into
masterfrom
new-api

Conversation

@gregziegan
Copy link
Copy Markdown
Owner

@gregziegan gregziegan commented Aug 15, 2016

Implementation of all the notes from #26

You can see what brought me to this API from this video

TODO:

  • API that allows the consumer to own the data
  • Support keydowns via subscription
  • Support sections
  • Allow for a single selection state (mouse & key unified)
  • Fix tests
  • Documentation

WAI-ARIA Compliance

Key and Mouse navigation:

Sections:

@maximsch2
Copy link
Copy Markdown
Contributor

Really excited to move to the new API. Out of curiosity: why did you require a new native module for a simple map function? Is it just a way to force-convert the type?

@gregziegan
Copy link
Copy Markdown
Owner Author

Correct! Talked w/ Evan about the strategy to get this published sooner than later. Attribute.map will be coming in the next release, so the native module is just an intermediary trick.

Won't have much time to merge and clean this up until the weekend. But also looking into subscriptions for menu only key events, may remove the input depending on the success of the subscriptions, and finally: menu sections like seen in react autosuggest.

I will also default as many attributes as possible to default WAI-ARIA compliance and do some screen reader testing.

@gregziegan gregziegan added this to the 4.0 milestone Aug 22, 2016
@gregziegan gregziegan mentioned this pull request Aug 23, 2016
@gregziegan
Copy link
Copy Markdown
Owner Author

Tests are currently not useful: Having a silent error on import. Looking into getting an sscce for elm-test. Not going to block a release on tests, though.

@gregziegan gregziegan changed the title [WIP] New API New API Aug 26, 2016
@gregziegan
Copy link
Copy Markdown
Owner Author

gregziegan commented Aug 30, 2016

Just got whitelisted
elm/package.elm-lang.org#199

So of course i'm going to wreak havoc with runtime errors 😈

Working on documentation now and want to have a WAI-ARIA support example, since I don't provide an input. I want to see when making that example if there's a way to provide a convenience function.

@gregziegan
Copy link
Copy Markdown
Owner Author

PR is getting too old, will make small PRs for the last points addressing issues directly

@gregziegan gregziegan merged commit 299ae09 into master Aug 30, 2016
@gregziegan gregziegan deleted the new-api branch August 30, 2016 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants