Diagnostic ping screen and chat screen added. Bugs fixed.#18
Merged
Conversation
Contributor
mangocat
commented
Nov 8, 2024
mangocat
commented
- Added the ping screen and chat screen. They can be accessed via the network screen.
- Fixed duplicate connection issue.
- Added some logs if errors occurred when connecting to another device. The QR code and Quick Share connecting methods now shares a function for better maintenance.
…e, the app will check if the new device is already connected to the mesh network. If it is already connected, the connection request will be dropped to avoid duplicate connection.
1. Delete Info Screen 2. Add Settings Screen 3. Design Settings Screen UI
kelvinlin9614
approved these changes
Nov 9, 2024
Collaborator
kelvinlin9614
left a comment
kelvinlin9614
left a comment
There was a problem hiding this comment.
Great update! Both the chat screen and ping screen are working well.
Here are a few aspects not covered in your description:
- Each line of chat history is copyable.
- The chat function was implemented using a database, the NanoHTTPD server, and the OkHTTP3 client. (Correct me if I was wrong)
I have a couple of suggestions:
- The "Ping" and "Send" buttons appear oddly on my Samsung phone but look fine on my tablet. (Minor fix)
- Perhaps we could retrieve all message history every time the app opens. Since we’re using a database, we could store messages in local storage and use the IP address and device name to match specific users. Not sure if it's worth it, but just a thought.
Overall, it’s a solid update!
Users can set the theme to "System," "Light," or "Dark." The app will remember their last choice and automatically apply it each time they open the app.
1. Implemented Language and Theme selection features. 2. Language Options: Follow System, English, Spanish, Chinese. 3. Theme Options: Follow System, Light, Dark. 4. Both language and theme preferences retain the user’s previous choice. 5. Preferences are automatically applied when the user reopens the app.
ccameron-gb
approved these changes
Nov 12, 2024
Collaborator
ccameron-gb
left a comment
ccameron-gb
left a comment
There was a problem hiding this comment.
An impressive set of changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.