WIP Adds bulk transfer ability during bulk checkout of Assets#18060
WIP Adds bulk transfer ability during bulk checkout of Assets#18060Godmartinz wants to merge 8 commits intogrokability:developfrom
Conversation
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
A couple notes from me skimming the code and then trying it out.
It feels weird to mix and match bulk checkout and bulk transfer in one action to me. Under the hood they are very similar so maybe I'm just getting hung up on it but it seems like there should be two menu items: one for bulk checkout and one for transfer. If we keep it under one menu item then we should let the user know which items they have selected are currently checked out and will be transferred. Just for their information.
| public function onAssetsTransferredInBulk(AssetsTransferredInBulk $event): void | ||
| { | ||
| Log::debug('event passed to the listener:'); | ||
| $event->transferable->logCheckout($event->note, $event->transferredTo, $event->transferable->last_checkout, $event->originalValues, true); |
There was a problem hiding this comment.
Hit an exception here: Property [last_checkout] does not exist on this collection instance.
| * 3. The item should send an email at check-in/check-out | ||
| */ | ||
|
|
||
| if (Context::get('action') === 'transfer') { |
There was a problem hiding this comment.
This should probably be bulk_transfer right?
| * 3. The item should send an email at check-in/check-out | ||
| */ | ||
|
|
||
| if (Context::get('action') === 'transfer') { |
There was a problem hiding this comment.
This should probably be bulk_transfer right?
2 participants
This is still a work in progress, but take a look as I think the bones of this PR are good.