-
Notifications
You must be signed in to change notification settings - Fork 4.7k
grpc: Fix cardinality violations in non-client streaming RPCs. #8385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
298edba
handled cardinality violation and added tests
Pranjali-2501 4c3a18a
Merge branch 'master' into server_streaming
Pranjali-2501 fd5d614
remove vet errors
Pranjali-2501 7e4206c
modified tests
Pranjali-2501 324566b
modified tests
Pranjali-2501 9fbf6b7
Merge branch 'master' into server_streaming
Pranjali-2501 9b9cddf
change server.recvmsg() to catch cardinality violation
Pranjali-2501 63565f2
Merge branch 'master' into server_streaming
Pranjali-2501 67549e7
replace srv with _
Pranjali-2501 6030b90
resolving comments
Pranjali-2501 dff08b3
resolving vets
Pranjali-2501 f4f1b61
addressed comments
Pranjali-2501 83e8664
resolving vets
Pranjali-2501 5acd9ab
resolving vets
Pranjali-2501 8f4f39b
minor change
Pranjali-2501 6de922d
minor change
Pranjali-2501 5f6c715
minor change
Pranjali-2501 990efe1
resolving comments
Pranjali-2501 7f6d31f
resolving nits
Pranjali-2501 41d8328
vet changes
Pranjali-2501 59ad122
added comment
Pranjali-2501 0f5248a
added comment
Pranjali-2501 1ff8868
resolving comments
Pranjali-2501 68fd0f8
update comment
Pranjali-2501 19e9e71
nits
Pranjali-2501 0d30b18
modifying test
Pranjali-2501 83fd598
resolving vet
Pranjali-2501 efa8e5a
remove comment
Pranjali-2501 29f6657
modifying tests
Pranjali-2501 183b1da
resolving comments
Pranjali-2501 749a52c
resolving comments
Pranjali-2501 1b1800d
resolving comments
Pranjali-2501 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-client-streaming was right before, wasn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, didn't realise while copying it.
Made the changes.