Skip to content

xds/cdsbalancer: changed the setupManagementServer helper to take listener and OnStreamReq as parameter #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eshitachandwani merged 12 commits into from
Aug 18, 2025
Merged

xds/cdsbalancer: changed the setupManagementServer helper to take listener and OnStreamReq as parameter #8467

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f0909e5
Update cdsbalancer_test.go
eshitachandwani Jul 22, 2025
2410c79
changes
eshitachandwani Aug 5, 2025
916870d
changes
eshitachandwani Aug 5, 2025
2892f4b
Merge branch 'grpc:master' into eshitachandwani-patch-2
eshitachandwani Aug 5, 2025
6ab5c5e
change test
eshitachandwani Aug 13, 2025
ba6af81
remove ctx
eshitachandwani Aug 13, 2025
2974342
add comment
eshitachandwani Aug 13, 2025
e74f6d1
change from to 2 function
eshitachandwani Aug 13, 2025
2c3d63b
make only one test
eshitachandwani Aug 13, 2025
2b47178
add s
eshitachandwani Aug 13, 2025
715d076
remove defaults
eshitachandwani Aug 14, 2025
97b05ce
remove unwanted commment
eshitachandwani Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion xds/internal/balancer/cdsbalancer/cdsbalancer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ func setupWithManagementServer(t *testing.T) (*e2e.ManagementServer, string, *gr
func setupWithManagementServerAndListener(t *testing.T, lis net.Listener) (*e2e.ManagementServer, string, *grpc.ClientConn, *manual.Resolver, xdsclient.XDSClient, chan []string, chan struct{}) {
t.Helper()

cdsResourceRequestedCh := make(chan []string, 1)
// If more than 10 requests are received and no reader is available,
// additional requests will be dropped due to the use of a non-blocking
// send using select with a default case.
cdsResourceRequestedCh := make(chan []string, 10)
cdsResourceCanceledCh := make(chan struct{}, 1)
mgmtServer := e2e.StartManagementServer(t, e2e.ManagementServerOptions{
Listener: lis,
Expand Down
Loading