CONTRIBUTING.md: Clarify the PR description section#8592
Closed
easwars wants to merge 1 commit intogrpc:masterfrom
Closed
CONTRIBUTING.md: Clarify the PR description section#8592easwars wants to merge 1 commit intogrpc:masterfrom
easwars wants to merge 1 commit intogrpc:masterfrom
Conversation
279547b to
0ea02fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8592 +/- ##
==========================================
+ Coverage 81.91% 81.96% +0.04%
==========================================
Files 415 415
Lines 40694 40694
==========================================
+ Hits 33336 33355 +19
+ Misses 5968 5956 -12
+ Partials 1390 1383 -7 🚀 New features to boost your workflow:
|
Member
|
As discussed offline, I am weary to add 20 lines to this already long document. Maybe we can solve our problems by providing a better template that includes the fields we want to see in the order we want to see them? E.g. |
Contributor
Author
|
I don't have the cycles to get this to the finish line at this point in time. Closing this now and will reopen when I can actually work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds more details to the "PR description" section and hopefully makes it easier for contributors to add PR titles and description that meets our requirements.
RELEASE NOTES: n/a