Skip to content

Conversation

@eshitachandwani
Copy link
Member

@eshitachandwani eshitachandwani commented Dec 17, 2025

Part of A74 changes. This PR changes the cdsbalancer to use the XDSConfig for resources and remove the cluster watcher from cds balancer.
Also removes the EDS/DNS watchers from the balancers and remove cluster resolver policy completely.

Note : Also includes changes from #8744 , will be removed after the PR is merged.
RELEASE NOTES:

  • xds:
    • Ambient error for cluster resource will now only be logged in dependency manager and not propagated to LB policies.
    • When a re-resolution is requested, all the LOGICAL_DNS type clusters will be re-resolved as opposed to just one.

@eshitachandwani eshitachandwani added this to the 1.79 Release milestone Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 75.53648% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.26%. Comparing base (4046676) to head (76fbed3).

Files with missing lines Patch % Lines
internal/xds/balancer/cdsbalancer/cdsbalancer.go 67.10% 33 Missing and 17 partials ⚠️
internal/xds/xdsdepmgr/xds_dependency_manager.go 88.63% 4 Missing and 1 partial ⚠️
internal/xds/balancer/cdsbalancer/configbuilder.go 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8777      +/-   ##
==========================================
- Coverage   83.42%   83.26%   -0.16%     
==========================================
  Files         418      411       -7     
  Lines       32897    32524     -373     
==========================================
- Hits        27443    27080     -363     
+ Misses       4069     4062       -7     
+ Partials     1385     1382       -3     
Files with missing lines Coverage Δ
balancer/pickfirst/pickfirst.go 89.11% <100.00%> (ø)
...ds/balancer/cdsbalancer/configbuilder_childname.go 100.00% <ø> (ø)
internal/xds/clusterspecifier/rls/rls.go 62.50% <100.00%> (ø)
internal/xds/resolver/xds_resolver.go 88.88% <100.00%> (+0.12%) ⬆️
internal/xds/balancer/cdsbalancer/configbuilder.go 93.15% <93.54%> (ø)
internal/xds/xdsdepmgr/xds_dependency_manager.go 88.57% <88.63%> (+7.70%) ⬆️
internal/xds/balancer/cdsbalancer/cdsbalancer.go 73.29% <67.10%> (-12.04%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars
Copy link
Contributor

easwars commented Dec 18, 2025

The test is still failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants