-
Notifications
You must be signed in to change notification settings - Fork 4.6k
xds: change cdsbalancer to use dependency manager and remove clusterresolver #8777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eshitachandwani
wants to merge
15
commits into
grpc:master
Choose a base branch
from
eshitachandwani:balancer_use_dep_mgr_new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
xds: change cdsbalancer to use dependency manager and remove clusterresolver #8777
eshitachandwani
wants to merge
15
commits into
grpc:master
from
eshitachandwani:balancer_use_dep_mgr_new
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8777 +/- ##
==========================================
- Coverage 83.42% 83.26% -0.16%
==========================================
Files 418 411 -7
Lines 32897 32524 -373
==========================================
- Hits 27443 27080 -363
+ Misses 4069 4062 -7
+ Partials 1385 1382 -3
🚀 New features to boost your workflow:
|
Contributor
|
The test is still failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of A74 changes. This PR changes the cdsbalancer to use the XDSConfig for resources and remove the cluster watcher from cds balancer.
Also removes the EDS/DNS watchers from the balancers and remove cluster resolver policy completely.
Note : Also includes changes from #8744 , will be removed after the PR is merged.
RELEASE NOTES: