credentials: add end-to-end tests for JWT call credentials behavior#8818
credentials: add end-to-end tests for JWT call credentials behavior#8818easwars merged 7 commits intogrpc:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8818 +/- ##
==========================================
+ Coverage 83.22% 83.28% +0.06%
==========================================
Files 417 414 -3
Lines 32920 32805 -115
==========================================
- Hits 27397 27321 -76
+ Misses 4110 4075 -35
+ Partials 1413 1409 -4 🚀 New features to boost your workflow:
|
iamrajiv
changed the title
iamrajiv
changed the title
Pranjali-2501
left a comment
Pranjali-2501
left a comment
There was a problem hiding this comment.
@iamrajiv , Thank you for taking the initiative to add the tests.
Pranjali-2501
changed the title
Pranjali-2501
left a comment
Pranjali-2501
left a comment
There was a problem hiding this comment.
The test looks good to me. I have minor nits.
Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
|
@easwars , assigning it to you for second review. |
|
@iamrajiv I'm sorry. I just realized that some of my comments are in direct contradiction to some of the previous comments made as part of the review process and now you are having to do double work. |
|
No worries at all, @easwars! I appreciate the thorough review. The feedback to split into focused tests makes sense it's much cleaner and easier to debug now. Thanks for taking the time to review! |
easwars
left a comment
easwars
left a comment
There was a problem hiding this comment.
Changes look good to me. Just a bunch of minor nits this time around.
…rpc#8818) This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97. Fixes grpc#8635 RELEASE NOTES: none --------- Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
…rpc#8818) This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97. Fixes grpc#8635 RELEASE NOTES: none --------- Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
4 participants
This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97.
Fixes #8635
RELEASE NOTES: none