Skip to content

test: use testpb alias in stream_test.go for proto messages.#8854

Merged
Pranjali-2501 merged 1 commit intogrpc:masterfrom
Pranjali-2501:deps-change
Jan 22, 2026
Merged

test: use testpb alias in stream_test.go for proto messages.#8854
Pranjali-2501 merged 1 commit intogrpc:masterfrom
Pranjali-2501:deps-change

Conversation

@Pranjali-2501
Copy link
Copy Markdown
Contributor

This change introduces a testpb alias for the google.golang.org/grpc/interop/grpc_testing import in stream_test.go, alongside the existing testgrpc alias.
We update TestUnaryClient_ServerStreamingMismatch to use testpb for Protocol Buffer message types (e.g., StreamingOutputCallResponse) while checking service interfaces via testgrpc. This distinction is necessary for compatibility with google3.

RELEASE NOTES: N/A

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.21%. Comparing base (3fb101d) to head (f246c66).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8854      +/-   ##
==========================================
+ Coverage   83.16%   83.21%   +0.05%     
==========================================
  Files         414      414              
  Lines       32720    32720              
==========================================
+ Hits        27210    27228      +18     
+ Misses       4089     4081       -8     
+ Partials     1421     1411      -10     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal assigned Pranjali-2501 and unassigned arjan-bal Jan 22, 2026
@Pranjali-2501 Pranjali-2501 merged commit c7ec4d9 into grpc:master Jan 22, 2026
16 checks passed
mbissa pushed a commit to mbissa/grpc-go that referenced this pull request Feb 16, 2026
This change introduces a `testpb` alias for the
`google.golang.org/grpc/interop/grpc_testing` import in
[stream_test.go](cci:7://file:///usr/local/google/home/pranjalisaxena/import/grpc-go/stream_test.go:0:0-0:0),
alongside the existing `testgrpc` alias.
We update
[TestUnaryClient_ServerStreamingMismatch](cci:1://file:///usr/local/google/home/pranjalisaxena/import/grpc-go/stream_test.go:72:0-146:1)
to use `testpb` for Protocol Buffer message types (e.g.,
`StreamingOutputCallResponse`) while checking service interfaces via
`testgrpc`. This distinction is necessary for compatibility with
google3.

RELEASE NOTES: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants