Skip to content

test: Fix flaky test TestServerStreaming_ClientCallSendMsgTwice in end2end_test.go. #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pranjali-2501 merged 3 commits into from
Mar 25, 2026
Merged

test: Fix flaky test TestServerStreaming_ClientCallSendMsgTwice in end2end_test.go. #9004

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b8658e
fixing flaky test
Pranjali-2501 Mar 24, 2026
e8be43e
changed loop structure
Pranjali-2501 Mar 24, 2026
af59c6d
resolving nit
Pranjali-2501 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/end2end_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3960,7 +3960,19 @@ func (s) TestServerStreaming_ClientCallSendMsgTwice(t *testing.T) {
// Block until the stream’s context is done. Second call to client.SendMsg
// triggers a RST_STREAM which cancels the stream context on the server.
<-stream.Context().Done()
if err := stream.SendMsg(&testpb.StreamingOutputCallRequest{}); status.Code(err) != codes.Canceled {
var err error
waitCtx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)
defer cancel()
for ; waitCtx.Err() == nil; <-time.After(time.Millisecond) {
err = stream.SendMsg(&testpb.StreamingOutputCallRequest{})
if err != nil {
break
}
}
if waitCtx.Err() != nil {
t.Fatalf("Context timed out waiting for stream.SendMsg() to return an error")
}
if status.Code(err) != codes.Canceled {
t.Errorf("stream.SendMsg() = %v, want error %v", err, codes.Canceled)
}
close(handlerDone)
Expand Down
Loading