interop-test: add opentelemetry tracing context propagation test#11538
Merged
YifeiZhuang merged 4 commits intogrpc:masterfrom Sep 28, 2024
Merged
interop-test: add opentelemetry tracing context propagation test#11538YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang merged 4 commits intogrpc:masterfrom
Conversation
DNVindhya
reviewed
Sep 20, 2024
Comment on lines
+154
to
+155
| // This is because census-tracing overrides the grpc-trace-bin header with | ||
| // OpenTelemetry's GrpcTraceBinPropagator. |
Contributor
There was a problem hiding this comment.
How does census-tracing overrides grpc-trace-bin header? Isn't it the other way around?
Member
Author
There was a problem hiding this comment.
I verified again the order, the otel interceptor will be run first.
Looking at the code, the census interceptor is added in the front of the interceptor list. And the otel interceptor is after. Then the otel interceptor will be run first. see interceptor channel.
DNVindhya
approved these changes
Sep 27, 2024
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-2-end test for trace context propagation from client application to server application. Unit test cases include:
#11500