interop-testing: Show full status for interop test failures#12317
Merged
ejona86 merged 1 commit intogrpc:masterfrom Aug 28, 2025
Merged
interop-testing: Show full status for interop test failures#12317ejona86 merged 1 commit intogrpc:masterfrom
ejona86 merged 1 commit intogrpc:masterfrom
Conversation
It's pretty annoying to see a test failure with "expected:<DEADLINE_EXCEEDED> but was:<INTERNAL>" and not know the description or throwable cause of the status. Introduce a convenience to include the full status on unexpected Status.Code. There were two usages of assertWithMessage() that did give nice errors; those were converted to this new utility. It'd be even better to make a StatusSubject, but that'd take more time and this was easy and still an improvement. This was created because we're seeing servlet test failures with INTERNAL code, and we need to see the details.
Contributor
|
Can be a truth extension like the following @NullMarked
public final class StatusSubject extends Subject {
private final @Nullable Status actual;
private StatusSubject(FailureMetadata metadata, @Nullable Status actual) {
super(metadata, actual);
this.actual = actual;
}
public void hasCode(Code expectedCode) {
if (actual == null) {
failWithoutActual(
fact("expected to have code", expectedCode),
simpleFact("but was null"));
} else {
check("getCode()").that(actual.getCode()).isEqualTo(expectedCode);
}
}
public void hasCodeAndDescription(Code expectedCode, String expectedDescription) {
if (actual == null) {
failWithoutActual(
fact("expected to have code", expectedCode),
fact("and description", expectedDescription),
simpleFact("but was null"));
} else {
check("getCode()").that(actual.getCode()).isEqualTo(expectedCode);
check("getDescription()").that(actual.getDescription()).isEqualTo(expectedDescription);
}
}
public static Factory<StatusSubject, Status> statuses() {
return StatusSubject::new;
}
}and then |
kannanjgithub
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's pretty annoying to see a test failure with
"
expected:<DEADLINE_EXCEEDED> but was:<INTERNAL>" and not know the description or throwable cause of the status. Introduce a convenience to include the full status on unexpected Status.Code. There were two usages of assertWithMessage() that did give nice errors; those were converted to this new utility.It'd be even better to make a StatusSubject, but that'd take more time and this was easy and still an improvement. This was created because we're seeing servlet test failures with INTERNAL code, and we need to see the details.