xds: bypass sidecar readiness for non-GRPC responses & fix draining conformance in ext_proc filter - #12914
Merged
Conversation
…onformance - Bypass sidecar readiness checks in `request(int)` when observability mode is false and response body mode is not `GRPC`. - Ensure that when response headers, body, or trailers are skipped/disabled, they bypass request draining and stream directly downstream instead of being blocked. - Fix sidecar mocks in tests to properly call `onCompleted()` when the request stream completes, preventing background stream leaks. - Set appropriate processing modes in existing tests to match their flow control expectations under the updated logic.
sauravzg
requested changes
Jul 23, 2026
…eaders draining Modifies the `testRequestBodyDrainingBypassedWhenRequestBodyModeNone` unit test to utilize a bidirectional streaming method (`METHOD_BIDI_STREAMING`) instead of a unary call. This allows the backend data plane server to send headers and responses back to the interceptor client listener before the client half-closes the call, ensuring the `isDraining && sendResponseHeaders` branch inside `onHeaders` is successfully reached and covered during the `DRAINING` state. Verifies that response headers and messages are correctly buffered while the external processor stream is draining, and are successfully delivered to the application listener once the external processor stream completes.
sauravzg
approved these changes
Jul 28, 2026
Allow DataPlaneClientCall.halfClose() to proceed immediately during ext_proc request draining if it is safe to do so. This is safe if: - RequestBodyMode is NONE. - RequestBodyMode is GRPC (or others) but no body messages have been sent to ext_proc and no messages are buffered. If messages have been sent to ext_proc, halfClose remains deferred until the ext_proc stream completes to ensure all messages are processed. This prevents hangs when the application calls halfClose during draining but no further interaction with ext_proc is needed.
kannanjgithub
deleted the
ext-proc-draining-skip-queueing-or-saving-headers-when-send-mode-is-off
branch
July 30, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request(int)when observability mode is false and response body mode is notGRPC.