fix: close frameReader before socket in stopIfNecessary to prevent TSAN data race - #12949
Open
waterWang wants to merge 1 commit into
Open
fix: close frameReader before socket in stopIfNecessary to prevent TSAN data race#12949waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10294
Description
The thread reads from the socket while closes the same socket on the thread. This causes a TSAN-detected data race in the JVM's SSL Cipher state:
Fix
In , close the 's before closing the (which triggers the socket close). This ensures the reader thread is stopped before the socket is closed, preventing the data race.
The causes the loop to exit, and its block handles the idempotently.