Add GRPC + TLS integration tests (notably, test important security properties) - #1324
Closed
matthild wants to merge 3 commits into
Closed
Add GRPC + TLS integration tests (notably, test important security properties)#1324matthild wants to merge 3 commits into
matthild wants to merge 3 commits into
Conversation
Collaborator
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
Regarding the request to sign the CLA: I have already registered my GitHub account internally, as a Google employee. Should I sign the CLA also? |
Member
|
@matthild, the CLA is based on the email address of the commits (i.e., mh@matth-red.local), not your GitHub account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds end-to-end tests of the following basic functionality:
GrpcSslContextscan successfully communicate with each other. (This last test fails -- any idea why?)These tests work by having an actual GRPC client talk through the operating system's network stack to an actual GRPC server listening on a port, and thus mimic how GRPC will behave in real-world applications.
(I have also drafted tests of some other important security properties, but suggest adding them later via a separate pull request, once these initial tests are in place. The additional tests will be easier to add in a sensible way if some organization of the test certificates directory happens first.)