Skip to content

Add GRPC + TLS integration tests (notably, test important security properties) - #1324

Closed
matthild wants to merge 3 commits into
grpc:masterfrom
matthild:matthild_tls_client_auth_test
Closed

Add GRPC + TLS integration tests (notably, test important security properties)#1324
matthild wants to merge 3 commits into
grpc:masterfrom
matthild:matthild_tls_client_auth_test

Conversation

@matthild

Copy link
Copy Markdown
Contributor

This pull request adds end-to-end tests of the following basic functionality:

  • A server configured to require client authentication refuses to accept connections from a client that has an untrusted certificate.
  • A server configured to require client authentication actually does require client authentication.
  • A client and a server configured using GrpcSslContexts can successfully communicate with each other. (This last test fails -- any idea why?)

These tests work by having an actual GRPC client talk through the operating system's network stack to an actual GRPC server listening on a port, and thus mimic how GRPC will behave in real-world applications.

(I have also drafted tests of some other important security properties, but suggest adding them later via a separate pull request, once these initial tests are in place. The additional tests will be easier to add in a sensible way if some organization of the test certificates directory happens first.)

@grpc-kokoro

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@matthild

Copy link
Copy Markdown
Contributor Author

Regarding the request to sign the CLA: I have already registered my GitHub account internally, as a Google employee. Should I sign the CLA also?

@ejona86

ejona86 commented Jan 19, 2016

Copy link
Copy Markdown
Member

@matthild, the CLA is based on the email address of the commits (i.e., mh@matth-red.local), not your GitHub account.

@matthild matthild closed this Jan 19, 2016
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants